FEATURE: Detect locale and translate posts from core table #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
force-pushed
the
post-translation
branch
from
5597c91 to
e3fe877
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces new functionality to automatically detect a post’s locale and generate translations via dedicated jobs and services. Key changes include:
- Adding jobs to translate posts and detect posts' locales.
- Implementing new translator and locale detector services using updated provider methods.
- Enhancing the provider API with separate methods for handling Post and Topic translation.
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/services/post_translator_spec.rb | Tests for post translation functionality |
| spec/services/post_locale_detector_spec.rb | Tests for post locale detection functionality |
| spec/jobs/translate_posts_spec.rb | Tests and implementation for translating posts job |
| spec/jobs/detect_posts_locale_spec.rb | Tests for detecting posts' locale job |
| app/services/discourse_translator/provider/discourse_ai.rb | Adds specific methods for translating posts and topics |
| app/services/discourse_translator/provider/base_provider.rb | Introduces wrapper methods for post and topic translation |
| app/services/discourse_translator/post_translator.rb | Implements post translation logic |
| app/services/discourse_translator/post_locale_detector.rb | Implements post locale detection logic |
| app/jobs/regular/translate_posts.rb | Implements the post translation job |
| app/jobs/regular/detect_posts_locale.rb | Implements the job to detect post locales |
Files not reviewed (1)
- .discourse-compatibility: Language not supported
nattsw
force-pushed
the
post-translation
branch
from
51cf6a2 to
333e3b5
Compare
tyb-talks
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two jobs that fill in
post.localeand addsPostLocalizationfor each defined locale inSiteSetting.automatic_translation_target_languages.It also creates dedicated
DiscourseTranslator::PostTranslatorandDiscourseTranslator::PostLocaleDetectorto serve this purpose. We should be moving away from dealing withtranslatablesin the near future.Needs the following to be merged:
Will require a compat file update after the above is merged.